Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Call.toArrayConstructor #9916

Merged
merged 1 commit into from
Dec 10, 2022
Merged

Fix Call.toArrayConstructor #9916

merged 1 commit into from
Dec 10, 2022

Conversation

perost
Copy link
Member

@perost perost commented Dec 10, 2022

  • Don't fail on fill-calls that don't have exactly two arguments.

@perost perost added COMP/OMC/Frontend Issue and pull request related to the frontend COMP/OMC/New Backend Issues and pull requests related to the new backend. labels Dec 10, 2022
@perost perost self-assigned this Dec 10, 2022
@perost perost enabled auto-merge (squash) December 10, 2022 19:42
@perost
Copy link
Member Author

perost commented Dec 10, 2022

@casella: This should fix the majority of the regressions in the latest newBackend test report. I thought it was due to the changes to the connection handling, but turns out it was just a minor issue in the code added by @kabdelhak instead.

- Don't fail on `fill`-calls that don't have exactly two arguments.
@perost perost merged commit 295b3b0 into OpenModelica:master Dec 10, 2022
@casella
Copy link
Contributor

casella commented Dec 12, 2022

@casella: This should fix the majority of the regressions in the latest newBackend test report.

Indeed, see the regression report 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMP/OMC/Frontend Issue and pull request related to the frontend COMP/OMC/New Backend Issues and pull requests related to the new backend.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants