[NF] implement a sanity check for discrete reals #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kabdelhak
commented
Jun 24, 2020
kabdelhak
commented
- discrete real variables have to be determined by a when equation or algorithm
- throw error if any discrete variables are not determined in such
- ticket The NF accepts illegal discrete variables #5836
kabdelhak
force-pushed
the
whenEquationFix_5836
branch
2 times, most recently
from
dba29ee
to
2d8d543
Compare
perost
approved these changes
Jun 24, 2020
| hashTable := BaseHashTable.add((cref, 0), hashTable); | ||
| then hashTable; | ||
|
|
||
| // kabdelhak: is checking connect necessary? Can there be connects in when equations? |
There was a problem hiding this comment.
No, connects are not allowed in when-equations and are rejected during the instantiation by the NF.
kabdelhak
force-pushed
the
whenEquationFix_5836
branch
3 times, most recently
from
0317905
to
90d0623
Compare
- discrete real variables have to be determined by a when equation or algorithm - throw error if any discrete variables are not determined in such - ticket OpenModelica#5836
- check nested if equations in when equations for discrete Real definitions - update model to be legal
kabdelhak
force-pushed
the
whenEquationFix_5836
branch
from
6bf087a
to
72fbf73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.