Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding libsuitesparseconfig to debian install #7

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

AnHeuermann
Copy link
Member

I also ordered the libs a tiny bit.

@AnHeuermann
Copy link
Member Author

@sjoelund This should fix https://trac.openmodelica.org/OpenModelica/ticket/6375. Can you review and merge if its looking correct?

@sjoelund
Copy link
Member

Ah, I thought suitesparse was used by OMC, too. So I had it as part of libomc. If you add the config to here, you need to remove it from the other file

@AnHeuermann
Copy link
Member Author

Ah I didn't even see you had fixed it already until just now.

SuiteSparse should only be used from the C and C++ runtime, but both link to the libs in lib/**/omc/. So I think adding them to https://github.com/OpenModelica/OpenModelicaBuildScripts/blob/master/debian/libomcsimulation.install should be better, at least the other SuiteSparse libs are there as well.

@AnHeuermann
Copy link
Member Author

Is the order important? I just sorted them alphabetically.
And how are the *.install files are used?

@sjoelund
Copy link
Member

Order doesn't matter. The files listed become part of the corresponding .deb package. You can't have the same file in two installed packages.

@AnHeuermann AnHeuermann changed the title Adding libsuitesparseconfig and libcolamd to debian install Adding libsuitesparseconfig to debian install Feb 15, 2021
@AnHeuermann
Copy link
Member Author

I think we should merge this PR so the master and maintenance/v1.17 branches are in sync.

@sjoelund sjoelund merged commit e1510c2 into OpenModelica:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants