Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pynbs fails to parse files with invalid CP1252 characters #22

Open
Bentroen opened this issue Dec 10, 2022 · 0 comments
Open

pynbs fails to parse files with invalid CP1252 characters #22

Bentroen opened this issue Dec 10, 2022 · 0 comments

Comments

@Bentroen
Copy link
Member

Commit 05efe72 changed the decoding of string bytes to use CP1252. Since NBS has an issue where it only saves the first byte of each character's UTF-16 representation (see OpenNBS/OpenNoteBlockStudio#307), this change was implemented to match its behavior, which manages to load files successfully despite showing corrupted characters.

However, CP1252 still has undefined codepoints, which, if present, still result in an exception while trying to parse the file:

From the Open Note Block Studio Discord:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant