Fix for issue 101: fails to compile on OSX #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On MacOSX, there is a library function equivalent(). The glh library included here sets equivalent as a macro which then causes a cascade of errors. This change uses a name within the header file that is unlikely to clash with a system name: switch to glh_equivalent.
The glh header files are used within the sample NiViewer, but are not used by any other sample. However each sample contains a complete copy of the unneccessary files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the code compile without error on OSX: fix a conflict with the equivalent() macro compared to a 'standard' equivalent() function provided on OSX. This is in the key file Samples/NiViewer/glh/glh_linear.h. I also removed unnecessary copies of the glh library so it doesn't need to be fixed in 5 places.