Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: return 204 no content when nothing is found #39

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Bug fix: return 204 no content when nothing is found #39

merged 1 commit into from
Aug 2, 2022

Conversation

BenjaminJ
Copy link
Contributor

ALEC-160

cgorantla
cgorantla approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@cgorantla cgorantla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BenjaminJ BenjaminJ merged commit 8c7edfd into develop Aug 2, 2022
RangerRick
RangerRick approved these changes Aug 2, 2022
View reviewed changes
Copy link

@RangerRick RangerRick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks straightforward to me

BenjaminJ added a commit that referenced this pull request Sep 20, 2022
@BenjaminJ
Bug fix: return 204 no content when nothing is found (#39)
8b70220 
Return NO CONTENT when no configuration found

ALEC-160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RangerRick RangerRick RangerRick approved these changes

@cgorantla cgorantla cgorantla approved these changes

@geraldhumphries geraldhumphries Awaiting requested review from geraldhumphries

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BenjaminJ @RangerRick @cgorantla