-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hellinger distance calculation to dbscan engine #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
O add rest endpoint to store data in db o add rest endpoint to configure and store engine parameter
O add rest endpoint to store data in db o add rest endpoint to configure and store engine parameter
O add rest endpoint to store data in db o add rest endpoint to configure and store engine parameter
O add rest endpoint to store data in db o add rest endpoint to configure and store engine parameter
O add rest endpoint to store data in db o add rest endpoint to configure and store engine parameter
O add rest endpoint to store data in db o add rest endpoint to configure and store engine parameter
O add rest endpoint to store data in db o add rest endpoint to configure and store engine parameter
O add rest endpoint to store data in db o add rest endpoint to configure and store engine parameter
O add rest endpoint to store data in db o add rest endpoint to configure and store engine parameter
O add rest endpoint to store data in db o add rest endpoint to configure and store engine parameter
o remove useless debug log o remove useless comment o remove TODO (partially fixed unit test) o add key value to parameter o fixed restImpl bean
o add BlueprintContextTest
o rewrite rest api
o rewrite rest api
o rewrite rest api
o rewrite rest api
o For convenience Response entity should return key before value
o use KeyStoreValue instead of implementing it o Use Agreement object instead of o clean up api (SetEngineConfiguration, GetEngineConfiguration, SetAgreementConfiguration, GetEngineConfiguration, GetConfigurations) o cleanup log with multiline
o use reference-list in bean initialization o rename engine and distanceMeasure parameter in EngineParameter.java ALEC-116, ALEC-122
o add hellinger to distanceMeasureFactoryMap ALEC-122
# Conflicts: # engine/api/src/main/java/org/opennms/alec/engine/api/DistanceMeasure.java # engine/dbscan/src/main/java/org/opennms/alec/engine/dbscan/AlarmInSpaceTimeDistanceMeasure.java # engine/dbscan/src/main/java/org/opennms/alec/engine/dbscan/DBScanEngineFactory.java # engine/dbscan/src/main/resources/OSGI-INF/blueprint/blueprint.xml # features/shell/src/main/java/org/opennms/alec/features/shell/ProcessAlarms.java # features/ui/src/main/java/org/opennms/alec/jackson/EngineParameterImpl.java # features/ui/src/main/java/org/opennms/alec/rest/ALECRestImpl.java
o fix hellinger compute method o cleanup code o add hellinger unit test ALEC-122
ALEC-122
…istanceMeasure o default value of epsilon is not the same in AlarmInSpaceTimeDistanceMeasure (100d) and HellingerDistanceMeasure (75d) o add hellinger unt tests ALEC-122
j-white
reviewed
Jul 28, 2022
datasource/opennms-direct/src/main/java/org/opennms/alec/datasource/opennms/jvm/ApiMapper.java
Outdated
Show resolved
Hide resolved
j-white
reviewed
Jul 29, 2022
datasource/opennms-direct/src/main/java/org/opennms/alec/datasource/opennms/jvm/ApiMapper.java
Outdated
Show resolved
Hide resolved
j-white
approved these changes
Jul 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Please squash.
BenjaminJ
added a commit
that referenced
this pull request
Sep 20, 2022
add hellinger distance measure to dbscan engine o add HellingerDistanceMeasure o default value of epsilon is not the same in AlarmInSpaceTimeDistanceMeasure (100d) and HellingerDistanceMeasure (75d) ALEC-122
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.opennms.org/browse/ALEC-122