Feature/alec 178 #59
Merged
Feature/alec 178 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-white
reviewed
Sep 8, 2022
features/deeplearning/src/main/java/org/opennms/features/deeplearning/shell/LoadModel.java
Outdated
Show resolved
Hide resolved
engine/deeplearning/src/main/java/org/opennms/alec/engine/deeplearning/TFModel.java
Outdated
Show resolved
Hide resolved
engine/dbscan/src/main/java/org/opennms/alec/engine/dbscan/DBScanEngineFactory.java
Outdated
Show resolved
Hide resolved
o Expanding archive files without controlling resource consumption is security-sensitive https://sonarcloud.io/organizations/opennms/rules?open=java%3AS5042&rule_key=java%3AS5042 ALEC-178
- Make sure publicly writable directories are used safely here. java:S5443 - Generic exceptions should never be thrown ALEC-178
- use of System.out intentionally in Karaf shell commands so that they show up in console output. LOGs aren't ideal here. - avoid adding a new checked exception here. This add a bunch of boilerplate, and can now lead to an NPE in calls to createEngine. - use java.io.tmpdir to avoid sonar java:S5443 (Make sure publicly writable directories are used safely here.) ALEC-178
BenjaminJ
force-pushed
the
feature/ALEC-178
branch
from
9319127
to
75fb018
Compare
BenjaminJ
requested review from
geraldhumphries,
amay94,
cgorantla,
fooker and
christianpape
ALEC-178
amay94
reviewed
Sep 23, 2022
engine/deeplearning/src/main/java/org/opennms/alec/engine/deeplearning/ClasspathUtils.java
Outdated
Show resolved
Hide resolved
amay94
reviewed
Sep 23, 2022
engine/deeplearning/src/main/java/org/opennms/alec/engine/deeplearning/ClasspathUtils.java
Outdated
Show resolved
Hide resolved
amay94
previously approved these changes
Sep 23, 2022
o fix comment at wrong line o filename could be set before the loop o all the zip entries are retrieved from the jarConnection, the if statement is redundant ALEC-178
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sonar Cloud Security Grade A - Figure out What We Need to Fix and Report the List