Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/alec 238 metrics events #73

Merged
merged 6 commits into from
Oct 27, 2022

Conversation

anyarybalova
Copy link
Contributor

No description provided.

chinh-work
chinh-work previously approved these changes Oct 27, 2022
@@ -17,18 +17,24 @@ const props = defineProps<{
}>()

const situation = ref(situationStore.situations[props.index])

let container = ref()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be a const

}>()
let maxWidth = ref(props.width)
let container = ref(props.width)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these could be const

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@anyarybalova anyarybalova merged commit 5329e6b into develop Oct 27, 2022
@anyarybalova anyarybalova deleted the feature/ALEC-238-metrics-events branch October 27, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants