OIA-2: Add service detectors api and sample detector #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-white
reviewed
Nov 19, 2018
There was a problem hiding this comment.
Looks good.
I think we may use reflection for setting the detector parameters in the ServiceDetector instances - does this still work in this context?
Can we also add support for executing detectors? This would also us to test a detector as part of of health:check in the sample project.
api/src/main/java/org/opennms/integration/api/v1/detectors/ServiceDetector.java
Show resolved
Hide resolved
api/src/main/java/org/opennms/integration/api/v1/detectors/ServiceDetector.java
Outdated
Show resolved
Hide resolved
mattixtech
reviewed
Nov 19, 2018
api/src/main/java/org/opennms/integration/api/v1/detectors/DetectResults.java
Show resolved
Hide resolved
sample/src/main/java/org/opennms/integration/api/sample/SampleDetector.java
Show resolved
Hide resolved
sample/src/main/java/org/opennms/integration/api/sample/SampleDetector.java
Show resolved
Hide resolved
j-white
reviewed
Nov 21, 2018
api/src/main/java/org/opennms/integration/api/v1/monitors/MonitoredService.java
Outdated
Show resolved
Hide resolved
sample/src/main/java/org/opennms/integration/api/sample/MyHealthCheck.java
Outdated
Show resolved
Hide resolved
api/src/main/java/org/opennms/integration/api/v1/detectors/DetectorRunner.java
Outdated
Show resolved
Hide resolved
api/src/main/java/org/opennms/integration/api/v1/detectors/DetectorRunner.java
Outdated
Show resolved
Hide resolved
cgorantla
force-pushed
the
oia-2
branch
2 times, most recently
from
c1916f5
to
bca3985
Compare
cgorantla
commented
Nov 28, 2018
| * | ||
| * @return a new @{@link ServiceDetector}. | ||
| */ | ||
| T createDetector(Map<String, String> properties); |
There was a problem hiding this comment.
Since now it is factory's responsibility to set bean properties, exposing it in Integration-API as well. Implementations can decide how to set those properties.
|
@j-white Thanks for the review. I think I addressed all issues. Please take another look. |
|
Removed spring dependency and upgraded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to service detecor API from provision:
removed setters, removed getIpMatch() as I see this is only used in LoopDetector so it may not be generic.
removed getServiceAttributes() as this is used only in WsManDetector.
service detector is always async in nature.
https://issues.opennms.org/browse/OIA-2