Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIA 46: implement classpath xml loader for poller config #70

Merged

Conversation

dherdt
Copy link
Contributor

@dherdt dherdt commented Sep 13, 2022

Jira: https://issues.opennms.org/browse/OIA-46

Based on jira/OIA-45_OIA_poller_configuration_extension (it needs to be merged first)

Copy link

@aramosvizcarra aramosvizcarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with poller but in general looks pretty good. Just one class seems to be incomplete.

@fooker fooker changed the title Jira/oia 46 implement classpath xml loader for poller config OIA 46: implement classpath xml loader for poller config Sep 22, 2022
@fooker fooker changed the base branch from master to jira/OIA-45_OIA_poller_configuration_extension September 22, 2022 08:56
Copy link
Member

@fooker fooker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to remove all serialVersionUID and default constructor implementations.

Base automatically changed from jira/OIA-45_OIA_poller_configuration_extension to master September 26, 2022 08:39
@dherdt dherdt force-pushed the jira/OIA-46_Implement_classpath_XML_loader_for_poller-config branch from e13e93d to 62a9788 Compare September 28, 2022 09:12
Copy link
Member

@fooker fooker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the equalsTo and hash methods are inconsistent. Please regenerate them.

dherdt and others added 3 commits September 30, 2022 17:47
…PollerConfigurationLoader.java

Co-authored-by: Dustin Frisch <dustin@opennms.com>
…XML_loader_for_poller-config' into jira/OIA-46_Implement_classpath_XML_loader_for_poller-config
@dherdt dherdt requested a review from fooker September 30, 2022 16:19
config/src/main/xsds/poller-configuration.xsd Outdated Show resolved Hide resolved
config/src/main/xsds/poller-configuration.xsd Outdated Show resolved Hide resolved
@dherdt dherdt requested a review from fooker October 4, 2022 10:01
Copy link
Contributor

@christianpape christianpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only two headers need fixes

…erConfigurationExtensionTest.java

Co-authored-by: Christian Pape <Christian.Pape@informatik.hs-fulda.de>
dherdt and others added 3 commits October 4, 2022 13:27
…erConfigurationExtension.java

Co-authored-by: Christian Pape <Christian.Pape@informatik.hs-fulda.de>
…erConfigurationExtensionTest.java

Co-authored-by: Christian Pape <Christian.Pape@informatik.hs-fulda.de>
…erConfigurationExtensionTest.java

Co-authored-by: Christian Pape <Christian.Pape@informatik.hs-fulda.de>
Copy link
Contributor

@christianpape christianpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dherdt dherdt merged commit f0548c9 into master Oct 4, 2022
@dherdt dherdt deleted the jira/OIA-46_Implement_classpath_XML_loader_for_poller-config branch October 4, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants