-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OIA 46: implement classpath xml loader for poller config #70
OIA 46: implement classpath xml loader for poller config #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with poller but in general looks pretty good. Just one class seems to be incomplete.
...ig/src/main/java/org/opennms/integration/api/xml/schema/poller/PollerClassObjectAdapter.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure to remove all serialVersionUID
and default constructor implementations.
config/src/main/java/org/opennms/integration/api/xml/ClasspathPollerConfigurationLoader.java
Outdated
Show resolved
Hide resolved
config/src/main/java/org/opennms/integration/api/xml/ClasspathPollerConfigurationLoader.java
Outdated
Show resolved
Hide resolved
config/src/main/java/org/opennms/integration/api/xml/ClasspathPollerConfigurationLoader.java
Outdated
Show resolved
Hide resolved
config/src/main/java/org/opennms/integration/api/xml/schema/poller/DowntimeXml.java
Outdated
Show resolved
Hide resolved
config/src/main/java/org/opennms/integration/api/xml/schema/poller/DowntimeXml.java
Outdated
Show resolved
Hide resolved
config/src/main/java/org/opennms/integration/api/xml/schema/poller/PackageXml.java
Outdated
Show resolved
Hide resolved
config/src/main/java/org/opennms/integration/api/xml/schema/poller/PollerConfigurationXml.java
Outdated
Show resolved
Hide resolved
config/src/main/java/org/opennms/integration/api/xml/schema/poller/ServiceXml.java
Outdated
Show resolved
Hide resolved
config/src/main/java/org/opennms/integration/api/xml/schema/poller/ServiceXml.java
Outdated
Show resolved
Hide resolved
e13e93d
to
62a9788
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the equalsTo
and hash
methods are inconsistent. Please regenerate them.
config/src/main/java/org/opennms/integration/api/xml/ClasspathPollerConfigurationLoader.java
Outdated
Show resolved
Hide resolved
config/src/main/java/org/opennms/integration/api/xml/schema/poller/ServiceXml.java
Outdated
Show resolved
Hide resolved
…PollerConfigurationLoader.java Co-authored-by: Dustin Frisch <dustin@opennms.com>
…ties, review changes
…XML_loader_for_poller-config' into jira/OIA-46_Implement_classpath_XML_loader_for_poller-config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only two headers need fixes
sample/src/main/java/org/opennms/integration/api/sample/MyPollerConfigurationExtension.java
Outdated
Show resolved
Hide resolved
sample/src/test/java/org/opennms/integration/api/sample/MyPollerConfigurationExtensionTest.java
Outdated
Show resolved
Hide resolved
sample/src/test/java/org/opennms/integration/api/sample/MyPollerConfigurationExtensionTest.java
Outdated
Show resolved
Hide resolved
sample/src/test/java/org/opennms/integration/api/sample/MyPollerConfigurationExtensionTest.java
Outdated
Show resolved
Hide resolved
…erConfigurationExtensionTest.java Co-authored-by: Christian Pape <Christian.Pape@informatik.hs-fulda.de>
…erConfigurationExtension.java Co-authored-by: Christian Pape <Christian.Pape@informatik.hs-fulda.de>
…erConfigurationExtensionTest.java Co-authored-by: Christian Pape <Christian.Pape@informatik.hs-fulda.de>
…erConfigurationExtensionTest.java Co-authored-by: Christian Pape <Christian.Pape@informatik.hs-fulda.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Jira: https://issues.opennms.org/browse/OIA-46
Based on jira/OIA-45_OIA_poller_configuration_extension (it needs to be merged first)