Skip to content
This repository has been archived by the owner on Jun 10, 2021. It is now read-only.

CMake: Remove hardcoded flags #7

Merged
merged 2 commits into from
Jan 24, 2017
Merged

CMake: Remove hardcoded flags #7

merged 2 commits into from
Jan 24, 2017

Conversation

jlorieux-systran
Copy link
Contributor

This pull request removes hardcoded flags in the cmake files to allow:

  • Building of Debug and Release versions, based on the standard CMAKE_BUILD_TYPE flag
  • Dynamic checking of OpenMP compiler capability

@guillaumekln guillaumekln merged commit ffbde15 into OpenNMT:master Jan 24, 2017
@jlorieux-systran jlorieux-systran deleted the cmake_openmp_and_allow_build_type branch January 24, 2017 13:33
@wsnooker wsnooker mentioned this pull request Feb 12, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guillaumekln guillaumekln guillaumekln approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jlorieux-systran @guillaumekln