Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to cibuildwheel #363

Merged
merged 4 commits into from
Jan 4, 2021
Merged

Switch to cibuildwheel #363

merged 4 commits into from
Jan 4, 2021

Conversation

keichi
Copy link
Contributor

@keichi keichi commented Jan 4, 2021

In preparation for building wheels for macOS (#133), this PR attempts to use cibuildwheel to build wheels. I am however facing two issues here:

  1. Test dependencies cannot be installed on Python 3.9 since TensorFlow hasn't released wheels for Python 3.9 yet.
  2. pip wheel does not allow reading files outside the directory where setup.py is located. As a result, I am manually copying README.md from the root directory to python/before building wheels.

Any advice is welcome.

Copy link
Collaborator

@guillaumekln guillaumekln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this.

python/tests/requirements.txt Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
python/tools/prepare_build_environment.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@guillaumekln guillaumekln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@guillaumekln guillaumekln merged commit 391cb26 into OpenNMT:master Jan 4, 2021
@keichi keichi deleted the cibuildwheel branch January 5, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants