Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request: Publish on Pip] #1261

Closed
andreaferretti opened this issue Feb 4, 2019 · 5 comments
Closed

[feature request: Publish on Pip] #1261

andreaferretti opened this issue Feb 4, 2019 · 5 comments

Comments

@andreaferretti
Copy link

Hi, is there a reason why OpenNMT-py is not published on Pip? I think it would be worthwhile, in order to make it easier to depend on it, and I see that OpenNMT-tf is already published there.

@vince62s vince62s changed the title Publish on Pip [feature request: Publish on Pip] Feb 4, 2019
@vince62s
Copy link
Member

vince62s commented Feb 4, 2019

yes we'll try to have this, good point.

@ruohoruotsi
Copy link

+1 that this would be very useful indeed. I currently use opennmt-py as a dependency for my diacritic restoration work and this would simplify packaging my lib (and pre-trained models) significantly.

@andreaferretti
Copy link
Author

Are there any updates on this point? Or possibly any other suggestions on how to depend on OpenNMT?

@multimeric
Copy link

Also, it would be nice for the dependencies to be defined in the setup.py rather than the requirements.txt, so that they get pulled in as part of the install process.

@vince62s vince62s closed this as completed Oct 2, 2019
@pltrdy
Copy link
Contributor

pltrdy commented Oct 2, 2019

Hi guys, we've been working on it and finally published OpenNMT-py on pip as release candidates (rc) for v1.0.0.

We introduce commands to call OpenNMT-py without pointing to *.py files : use instead onmt_train, onmt_preprocess, onmt_server, onmt_translate.

Command line options remains unchanged and we kept preprocess/train/translate/server.py in root for compatibility.

Feel free to use it and give us feedback about that !

https://pypi.org/project/OpenNMT-py/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants