[WIP] Keep track of loaded shards #1826
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoishernandez
force-pushed
the
track_shards
branch
from
8c52dc7
to
d5e8f61
Compare
francoishernandez
force-pushed
the
track_shards
branch
from
d5e8f61
to
0c5544e
Compare
BramVanroy
reviewed
Jul 27, 2020
| @@ -706,6 +706,32 @@ def __iter__(self): | |||
| return | |||
|
|
|||
|
|
|||
| class Tracker(object): | |||
There was a problem hiding this comment.
Perhaps Tracker is a bit of a vague name? Suggestions: DataTracker of DataProgressTracker.
BramVanroy
reviewed
Jul 27, 2020
Comment on lines
+100
to
+101
| if tracker_queue is not None: | ||
| data_tracker = tracker_queue.get() |
There was a problem hiding this comment.
Doesn't this conflict with the initialised data_tracker above? (not sure) In which event would a data_tracker not be initialised but only available in the queue?
|
Even though I am not entirely sure of how this works, it seems good to me. You seem to track the latest shard that has been used during training and also save it in the checkpoints. When continuing training, the latest shard can then be used. Smart! I wrote some question inline but those are not critiques but rather questions to better understand what is going on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would allow to restart from (approximately) the same point in the data when continuing some training, instead of restarting from shard 0 each time.