Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix None grads and implicit dimension #799

Merged
merged 1 commit into from Jul 6, 2018
Merged

fix None grads and implicit dimension #799

merged 1 commit into from Jul 6, 2018

Conversation

pltrdy
Copy link
Contributor

@pltrdy pltrdy commented Jul 4, 2018 •
edited

  1. fix None grads:

  2. Implicit softmax dimension:

@pltrdy pltrdy mentioned this pull request Jul 4, 2018
Open
@srush srush merged commit 698b1ad into OpenNMT:master Jul 6, 2018
@vince62s vince62s deleted the small_fixes branch January 1, 2019 14:10
saikat107 pushed a commit to saikat107/OpenNMT-py that referenced this pull request Mar 12, 2019
@srush
Merge pull request OpenNMT#799 from Ubiqus/small_fixes
e406566 
fix None grads and implicit dimension
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pltrdy @srush