This repository has been archived by the owner on Jun 10, 2021. It is now read-only.
Input vectors #168
Merged
Input vectors #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # onmt/Factory.lua # onmt/data/Preprocessor.lua # onmt/translate/DecoderAdvancer.lua # onmt/translate/Translator.lua # preprocess.lua # translate.lua
onmt/Factory.lua
Outdated
| opt.pre_word_vecs_enc, opt.fix_word_vecs_enc == 1, | ||
| verbose) | ||
| else | ||
| inputNetwork = nn.Identity() |
There was a problem hiding this comment.
I think it should be in another function, like buildInputEncoder.
| @@ -110,6 +110,23 @@ function PDBiEncoder:maskPadding() | |||
| self.layers[1]:maskPadding() | |||
| end | |||
|
|
|||
| -- size of context vector | |||
| function PDBiEncoder:contextSize(sourceSize, sourceLength) | |||
There was a problem hiding this comment.
Why do we need that? Past the first layer, padding no more applies.
There was a problem hiding this comment.
contextSize is used in decoder to have size of the context size outside of the encoder which varies for pdbiencoder
preprocess.lua
Outdated
| if dataType == 'monotext' then | ||
| src_file = opt.train | ||
| end | ||
| data.dicts.src = Vocabulary.init('train', |
There was a problem hiding this comment.
Can we keep 'source' instead? See #162.
geffy
reviewed
Apr 23, 2017
| @@ -74,14 +74,24 @@ function Batch:__init(src, srcFeatures, tgt, tgtFeatures) | |||
|
|
|||
| self.sourceLength, self.sourceSize, self.uneven = getLength(src) | |||
|
|
|||
| -- if input vectors (speech for instance) | |||
| self.inputVectors = src[1]:dim() > 1 | |||
There was a problem hiding this comment.
This fails with default constructor like local batch = Batch()
There was a problem hiding this comment.
Good catch! It has been fixed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 2 new features for adding support of input vectors
-idx_filesindicate that source/target files are indexed meaning that their format iskey valuenot necessarily in the same orderfeattextwhich is using Kaldi text ark dump formatTypical preprocessing command:
For training:
For decoding: