Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in DojoAMDRuntimeModule #377

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

dpwatrous
Copy link
Contributor

Fixes #376

@CLAassistant
Copy link

CLAassistant commented Aug 24, 2023

CLA assistant check
All committers have signed the CLA.

@dpwatrous
Copy link
Contributor Author

I'm not confident this is the best way to fix this issue, but it worked for me.

@chuckdumont
Copy link
Collaborator

Thanks @dpwatrous, this fix looks fine.

But first I need to figure out why pull request builds are no longer working on this project.

@dpwatrous
Copy link
Contributor Author

Thanks @chuckdumont! FYI I've already patched it locally, so there's no rush as far as I'm concerned. Just figured I'd contribute back the fix.

@chuckdumont
Copy link
Collaborator

@dpwatrous - please push another commit to your branch to trigger a PR build. Maybe add a comment to your change like "Not the main compiler so ignore"

@dpwatrous
Copy link
Contributor Author

@chuckdumont sorry for the delay - just saw your last comment! I just reworded my commit messsage and force-pushed. Looks like Travis is running.

@coveralls
Copy link

Coverage Status

coverage: 98.314% (-0.1%) from 98.435% when pulling 787a124 on dpwatrous:dpwatrous/generate-bugfix into 5324894 on OpenNTF:master.

@chuckdumont chuckdumont merged commit 37c00fc into OpenNTF:master Sep 29, 2023
2 of 3 checks passed
@chuckdumont
Copy link
Collaborator

Fix is available in release 3.0.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in DojoAMDRuntimeModule.generate() when used with MonacoEditorWebpackPlugin
4 participants