Addition of Extension Point for EMBridge Subscriber Providers #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extension point allows IEMBridgeSubscriberProviders to be registered that will provide a list of IEMBridgeSubscribers to be added during startup of the IEMBridgeMessageQueue
|
How about logging the statement to a logger? Then you can decide at runtime what to show! |
|
I am using Serdar's XLogBack in my own plugins which is really great for this (and I like how it re-loads the logging config on the fly) I'm not sure what the ODA project recommends? I have seen a few System.out's around so I thought I would follow suit but I am happy to change it to something more suitable. |
|
Logging is mea culpa without a doubt. We've got multiple loggers available in org.openntf.domino.logging - one to OpenLog, one to the console and one to a text file in IBM_TECHNICAL_SUPPORT. I was very new to logging in Java at the time! |
|
If you see a System.out that's almost definitely my lazy ass. :)
…On Tue, Mar 28, 2017 at 1:11 AM, Paul Withers ***@***.***> wrote:
Logging is mea culpa without a doubt. We've got multiple loggers available
in org.openntf.domino.logging - one to OpenLog, one to the console and one
to a text file in IBM_TECHNICAL_SUPPORT. I was very new to logging in Java
at the time!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#160 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACoex81act_o1nZL7SBaSDUsAr-R8uaIks5rqLKegaJpZM4MrE1D>
.
|
|
haha many times I stare at the production console "Who the hell committed these System.out's? .... oh ... my bad" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extension point allows IEMBridgeSubscriberProviders to be registered that will provide a list of IEMBridgeSubscribers to be added during startup of the IEMBridgeMessageQueue
I've included a System.out.println("..") statement to output a message when a SubscriberProvider is being used. But let me know if you want to comment it out (I'm not sure on ODA Policy on use of console but I think this is handy to have to double check they are loading).
Also this code adds a plugin dependency on org.eclipse.core.runtime