Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix <registerAutoPackageIO> to not do so much work at invocation time #28

Closed
jamadden opened this issue Sep 21, 2017 · 0 comments
Closed

Fix <registerAutoPackageIO> to not do so much work at invocation time #28

jamadden opened this issue Sep 21, 2017 · 0 comments
Labels
enhancement
Milestone
1.0 Final

Comments

@jamadden
Copy link
Member

Instead it needs to defer it to execution time, after all directives have been processed and chances for conflicts have been resolved. As it is, it could leave things in a partial state.

For the classes that it modifies, ideally it should also register some zope.testing.cleanup actions to reset things, but that's relatively low priority given what it does.
@jamadden jamadden added this to the 1.0 Final milestone Sep 22, 2017
@jamadden jamadden mentioned this issue Sep 28, 2017
Closed
jamadden added a commit that referenced this issue Sep 28, 2017
@jamadden
Make ext:registerAutoPackageIO defer its legacy registrations
e50e5ae 
This lets it detect conflicts. This also lets it be used with
<registerIn> to localize them (yay).

I did *not* add an escape hatch to make it register them eagerly still
and ignore conflicts, but we can if that turns out to be necessary.

Fixes #28
@jamadden jamadden mentioned this issue Sep 28, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.0 Final
Development

No branches or pull requests
1 participant
@jamadden