Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove special handling of Creator from choose_field #59

Closed
jamadden opened this issue Jul 5, 2018 · 0 comments
Closed

Remove special handling of Creator from choose_field #59

jamadden opened this issue Jul 5, 2018 · 0 comments

Comments

@jamadden
Copy link
Member

jamadden commented Jul 5, 2018 •
edited

This is undocumented behaviour that really belongs in to_standard_external_creator (another internal function, renamed to standard_fields.get_creator in #58). I only find one use of choose_field outside of this package (including in the dataserver), and it doesn't hit that special case, so this should be completely safe.

choose_field is a hot function so simplifiying it is good.
jamadden added a commit that referenced this issue Jul 5, 2018
@jamadden
Remove special handling of creator from choose_field. Instead it is d…
f097171 
…one by get_creator.

get_creator no longer calls choose_field, it doesn't use any of the special features that were possible (like adaptation). This lets cython directly call system_user_converter.

Fixes #59.
@jamadden jamadden mentioned this issue Jul 5, 2018
Merged
jamadden added a commit that referenced this issue Jul 5, 2018
@jamadden
Remove special handling of creator from choose_field. Instead it is d…
cd02568 
…one by get_creator.

get_creator no longer calls choose_field, it doesn't use any of the special features that were possible (like adaptation). This lets cython directly call system_user_converter.

Fixes #59.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jamadden