Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependency on zope.preference. #41

Merged
merged 1 commit into from
Sep 28, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,6 @@
be registered locally with ``z3c.baseregistry`` (previously they
were always registered in the global site manager).
See https://github.com/NextThought/nti.externalization/issues/28
- Drop dependency on ``zope.preference``. It was not used by this
package, although our ``configure.zcml`` did include it. If you use
``zope.preference``, please include it in your own ZCML file.
3 changes: 1 addition & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,7 @@ def _read(fname):
'zope.intid',
'zope.lifecycleevent',
'zope.location',
'zope.mimetype',
'zope.preference',
'zope.mimetype >= 2.3.0',
'zope.proxy',
'zope.schema',
'zope.security',
Expand Down
3 changes: 0 additions & 3 deletions src/nti/externalization/configure.zcml
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@

<include package="zope.annotation" />

<include package="zope.preference" file="meta.zcml" />
<include package="zope.preference" />

<subscriber provides=".interfaces.IExternalMappingDecorator"
for="zope.dublincore.interfaces.IDCExtended"
factory=".dublincore.DCExtendedExternalMappingDecorator" />
Expand Down