Skip to content

Commit

Permalink
Rename for clarity
Browse files Browse the repository at this point in the history
  • Loading branch information
Joshua Zuech committed Apr 17, 2017
1 parent e47ff06 commit b972eb3
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions src/nti/transactions/tests/test_transaction.py
Expand Up @@ -25,7 +25,7 @@
from nti.transactions.interfaces import AbortFailedError

from nti.transactions.transactions import do
from nti.transactions.transactions import do_last
from nti.transactions.transactions import do_near_end
from nti.transactions.transactions import _do_commit
from nti.transactions.transactions import TransactionLoop

Expand Down Expand Up @@ -235,7 +235,7 @@ def test_call(x):
# except for the one that requests to go last.
manager1 = do(call=test_call, args=(0,))
manager2 = do(call=test_call, args=(1,))
manager_post = do_last(call=test_call, args=(10,))
manager_post = do_near_end(call=test_call, args=(10,))
manager3 = do(call=test_call, args=(2,))
transaction.commit()
assert_that(results, contains(0,1,2,10))
14 changes: 7 additions & 7 deletions src/nti/transactions/transactions.py
Expand Up @@ -196,7 +196,7 @@ def rollback(self):
# anyway.
pass

class ExecuteLastObjectDataManager(ObjectDataManager):
class OrderedNearEndObjectDataManager(ObjectDataManager):
"""
A special extension of :class:`ObjectDataManager` that attempts to execute
after all other data managers have executed. This is useful when an
Expand All @@ -208,7 +208,7 @@ def sortKey(self):
Sort prepended with z's in an attempt to execute after other data
managers.
"""
parent_key = super(ExecuteLastObjectDataManager, self).sortKey()
parent_key = super(OrderedNearEndObjectDataManager, self).sortKey()
sort_str = str(self.target) if self.target is not None else str(self.callable)
return 'zzz%s:%s' % (sort_str, parent_key)

Expand Down Expand Up @@ -249,19 +249,19 @@ def do(*args, **kwargs):
Establishes a IDataManager in the current transaction.
See :class:`ObjectDataManager` for the possible arguments.
"""
result = ObjectDataManager(*args, **kwargs)
klass = kwargs.pop('datamanager_class', ObjectDataManager)
result = klass(*args, **kwargs)
transaction.get().join(result)
return result

def do_last(*args, **kwargs):
def do_near_end(*args, **kwargs):
"""
Establishes a IDataManager in the current transaction that will attempt to
execute *after* all other DataManagers have had their say.
See :class:`ObjectDataManager` for the possible arguments.
"""
result = ExecuteLastObjectDataManager(*args, **kwargs)
transaction.get().join(result)
return result
kwargs['datamanager_class'] = OrderedNearEndObjectDataManager
return do(*args, **kwargs)

def _do_commit(tx, description, long_commit_duration):
exc_info = sys.exc_info()
Expand Down

0 comments on commit b972eb3

Please sign in to comment.