Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: standardize source files type and remove __unused from types #21

Merged
merged 1 commit into from
May 9, 2023

Conversation

edusperoni
Copy link
Contributor

the change to autolink-info fixes an issue where if a package specifies a single string as source files, open native would fail to link it

For example:

source_files: someFiles/**

when doing [...commonSourceFiles, the result would be: ['s', 'o', 'm', 'e'..... So now we standardize the type as always an array of strings.

The change to method solves the issue where the type would start with __unused when it was left by the package developer (in this case @react-native-community/netinfo)

@ammarahm-ed ammarahm-ed merged commit 1b57582 into OpenNative:main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants