M #-: Add sanity check on PHYDEV

Related to issue #6367, PHYDEV maybe an empry string. This commit adds an additional sanity check on PHYDEV to skip any configuration if it is empty
OpenNebula · Nov 8, 2023 · 2808f43 · 2808f43
1 parent 450443e
commit 2808f43
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/mad/ruby/DriverExecHelper.rb b/src/mad/ruby/DriverExecHelper.rb
@@ -207,7 +207,7 @@ def read_configuration
                     config[name]=value
                 end
             end
-        rescue StandardException => e
+        rescue StandardError => e
             STDERR.puts "Error reading config: #{e.inspect}"
             STDERR.flush
         end

diff --git a/src/vnm_mad/remotes/lib/no_vlan.rb b/src/vnm_mad/remotes/lib/no_vlan.rb
@@ -43,7 +43,8 @@ def activate
                 create_bridge(@nic)
 
                 # Return if vlan device is already in the bridge.
-                next if !@nic[:phydev] || @bridges[@nic[:bridge]].include?(@nic[:phydev])
+                next if !@nic[:phydev] || @nic[:phydev].empty? ||
+                        @bridges[@nic[:bridge]].include?(@nic[:phydev])
 
                 # Add phydev device to the bridge.
                 OpenNebula.exec_and_log("#{command(:ip)} link set " \
@@ -97,8 +98,8 @@ def deactivate
                     next if keep
 
                     # Delete the bridge.
-                    OpenNebula.exec_and_log("#{command(:ip)} link delete"\
-                        " #{@nic[:bridge]}")
+                    OpenNebula.exec_and_log("#{command(:ip)} link delete #{@nic[:bridge]}")
+
                     @bridges.delete(@nic[:bridge])
                 end
             end
@@ -122,7 +123,7 @@ def update(vnet_id)
                     @nic = nic
 
                     next unless Integer(@nic[:network_id]) == vnet_id
-                    next if @bridges[@nic[:bridge]].include? @nic[:phydev]
+                    next if @nic[:phydev].empty? || @bridges[@nic[:bridge]].include?(@nic[:phydev])
 
                     # Del old phydev device from the bridge.
                     OpenNebula.exec_and_log("#{command(:ip)} link set " \