noVNC is not working for VMs with password enabled

[kvaps]

Description
After upgrade to 5.8.4 I faced with the issue when most of VMs have no working VNC. Usually it is stacks on this screen without any errors:

But after few minutes, it shows:

and error in browser's console:

Failed when connecting: Connection closed (code: 1006) rfb.js:677
    _fail rfb.js:677
    RFB rfb.js:277
    onclose websock.js:227

To Reproduce

• Create VM with

  GRAPHICS = [
    LISTEN = "0.0.0.0",
    RANDOM_PASSWD = "YES",
    TYPE = "VNC" ]
  

• Try to connect via VNC

Expected behavior
Connected VNC

Details

• Affected Component: Sunstone
• Hypervisor: KVM
• Version: 5.8.4

Additional context

After rollback to 5.8.1 vnc is working again

Progress Status

• Branch created
• Code committed to development branch
• Testing - QA
• Documentation
• Release notes - resolved issues, compatibility, known issues
• Code committed to upstream release/hotfix branches
• Documentation committed to upstream release/hotfix branches

[alitvak69]

I have noticed some slowness, whence a black bar in the beginning. However, it loads the console in a few seconds.

[kvaps]

Looks like novnc client problem, I have sunstone and novnc-server running in separated containers.

So I can confirm that problem not in novnc-server but in client, I've tested few scenarios:

• Sunstone 5.8.1 and novnc server from 5.8.4 - working fine
• Sunstone 5.8.4 and novnc server from 5.8.4 - can't connect to some VMs

I also made dump of packets on the host with the both VMs to see what is actually wrong there:

Left side - bad case, Right side - good case

What did I found, actually nothing, just see that after 10th packets novnc-server does not sends any packets.

[kvaps]

Got it! Problem occurs only for VMs with enabled password authentication for VNC, however spice client is working fine

[kvaps]

probably it is stopped working after #3353

[tinova]

thanks kvaps and tryfunc!

[goncaloist]

Hello. I have been testing opennebula 5.8.5 and noticed that apparently this issue was not completely resolved with the fix.

The VNC windows is now available when using a password, but is still not displayed when the option "Open in a new Windows" is then used.

I also tried inserting the fix manually and rebuilding the 5.8.4 packages, with the same result. Hope that this issue was the right place in which to pass this information (reopening the issue?).

[jloboescalona2]

hi, @goncaloist, when you click on the "Open in a new Windows" button in the url do these parameters come out? a &encrypt=no&title=TITLEVM&password=PASSWORD

[kvaps]

I've install 5.8.5 and found that now password is working for VNC for me

[kvaps]

But as @goncaloist said button is not working anymore:

[kvaps]

Hm, it seems after restart sunstone and memcache is started working as it should

[goncaloist]

hi, @goncaloist, when you click on the "Open in a new Windows" button in the url do these parameters come out? a &encrypt=no&title=TITLEVM&password=PASSWORD

Hello. I was seeing only: "&encrypt=yes&title=TITLEVM". Now tried adding the &password=... and it worked.
I noticed that my "vnc_request_password" option was set to true. Changed it back to false and it now opens the new window. I had misunderstood the purpose of that option. It was no bug, working as intended.
Sorry, I had stumbled in this bug with 5.8.4 previously and though my "open in new window" issue was something related.