Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong MariaDB version detected over MySQL libs. #3924

Closed
7 tasks
vholer opened this issue Nov 7, 2019 · 0 comments
Closed
7 tasks

Wrong MariaDB version detected over MySQL libs. #3924

vholer opened this issue Nov 7, 2019 · 0 comments

Comments

@vholer
Copy link
Contributor

vholer commented Nov 7, 2019

Description
When database client is connecting with MySQL client libs to the MariaDB server, the database version detection for the FTS can catch the wrong version here:

one/src/sql/MySqlDB.cc

Lines 367 to 373 in 6db6c3f

bool MySqlDB::fts_available()
{
unsigned long version;
version = mysql_get_server_version(db_escape_connect);
if (version >= 50600)

because the MariaDB server can be (or is always?) identified to the MySQL client as composition of 2 versions (5.5.5-10.3.11-MariaDB). Example of full text identification:

Server version: 5.5.5-10.3.11-MariaDB MariaDB Server

The function mysql_get_server_version returns the first part with value 50505. Then the FTS indexes are not created and FTS search doesn't work. Strange thing is that it doesn't apply to Ruby MySQL connector (the DB upgrades) where @db.server_version gets 100311 as expected.

Tasks:

  • fts_available should deal with MariaDB versioning when connected w/ MySQL libs.
  • NICE TO HAVE: dump server identification on connect into oned.log + incl. state of various optional features (FTS for now)

Details

  • Affected Component: Core
  • Version: 5.9.90

Progress Status

  • Branch created
  • Code committed to development branch
  • Testing - QA
  • Documentation
  • Release notes - resolved issues, compatibility, known issues
  • Code committed to upstream release/hotfix branches
  • Documentation committed to upstream release/hotfix branches
@vholer vholer added this to the Release 5.10 milestone Nov 7, 2019
@tinova tinova modified the milestones: Release 5.10, Release 5.10.1 Nov 26, 2019
@tinova tinova modified the milestones: Release 5.10.1, Release 5.10.2 Dec 11, 2019
@tinova tinova modified the milestones: Release 5.10.2, Release 5.10.3 Feb 12, 2020
christian7007 pushed a commit to christian7007/one that referenced this issue Mar 30, 2020
christian7007 pushed a commit to christian7007/one that referenced this issue Mar 30, 2020
rsmontero added a commit that referenced this issue Mar 31, 2020
rsmontero added a commit to OpenNebula/docs that referenced this issue Mar 31, 2020
atodorov-storpool pushed a commit to storpool/one that referenced this issue Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants