logrotate configuration adding global defaults affecting other system logs

[willx0]

Description
Current logrotate configuration as included in the opennebula packages eg. /etc/logrotate.d/opennebula, is adding defaults to the global logrotate configuration changing the naming of other system logs.

To Reproduce
Running logrotate will add the date extension specified in the opennebula logrotate config on other system logs and cause them to be retained for 52 weeks unless explicitly configured otherwise.

Expected behavior
Logrotate options should only affect opennebula logs in /var/log/one directory.

Details

• Affected Component: core
• Version: 5.10.1

Current configuration:

one/share/pkgs/logrotate/opennebula

Lines 1 to 13 in 424ab04

	delaycompress
	dateext
	dateformat -%Y%m%d-%s
	compress
	weekly
	rotate 52
	/var/log/one/one_xmlrpc.log /var/log/one/oned.log {
	missingok
	notifempty
	copytruncate
	}

Options should be moved into the log stanza:

/var/log/one/one_xmlrpc.log /var/log/one/oned.log {
    missingok
    notifempty
    copytruncate
    delaycompress
    dateext
    dateformat -%Y%m%d-%s
    compress 
    weekly
    rotate 52
}

Additional context
This problem applies to all other logrotate configs eg. opennebula-econe, opennebula-flow, etc.

A single configuration as follows would negate the need for separate configs for the other components:

/var/log/one/*.log {
    missingok
    notifempty
    copytruncate
    delaycompress
    dateext
    dateformat -%Y%m%d-%s
    compress 
    weekly
    rotate 52
}

Progress Status

• Branch created
• Code committed to development branch
• Testing - QA
• Documentation
• Release notes - resolved issues, compatibility, known issues
• Code committed to upstream release/hotfix branches
• Documentation committed to upstream release/hotfix branches

[vholer]

Nice catch, thanks @willx0 !

PRs to merge into master:

• one: B #4557: Logrotates don't touch global defaults #4592
• docs: B OpenNebula/one#4557: What's new docs#1077