Sunstone missbehave with context attributes filled by vm_template_contents

[baby-gnu]

Description

Sunstone:

• duplicates prefilled attributes when instanciating a service with user or admin views
• clear prefilled attributes when instanciating a service with cloud view

To Reproduce

1. Import ttylinux apps
2. Modify the ttylinux VM template with the following template

   CONTEXT = [
     CONFIG1 = "$CONFIG1",
     CONFIG2 = "$CONFIG2",
     NETWORK = "YES",
     SSH_PUBLIC_KEY = "$USER[SSH_PUBLIC_KEY]" ]
   CPU = "0.1"
   DISK = [
     IMAGE_ID = "0" ]
   GRAPHICS = [
     LISTEN = "0.0.0.0",
     TYPE = "VNC" ]
   HOT_RESIZE = [
     CPU_HOT_ADD_ENABLED = "NO",
     MEMORY_HOT_ADD_ENABLED = "NO" ]
   INPUTS_ORDER = "CONFIG1,CONFIG2,SERVICE_CONFIG1,SERVICE_CONFIG2"
   LOGO = "images/logos/linux.png"
   MEMORY = "128"
   MEMORY_UNIT_COST = "MB"
   OS = [
     BOOT = "" ]
   USER_INPUTS = [
     CONFIG1 = "M|text|first config| |",
     CONFIG2 = "M|text|second config| |" ]
   

3. Create a test-service with the following content

   {
     "name": "test-service",
     "deployment": "straight",
     "description": "",
     "roles": [
       {
         "name": "r1",
         "cardinality": 1,
         "vm_template": 0,
         "vm_template_contents": "NIC = [\n  NAME = \"_NIC0\",\n  NETWORK_ID = \"$Public\" ]\nCONFIG1 = \"foor1\"\nCONFIG2 = \"barr1\"\n ",
         "elasticity_policies": [],
         "scheduled_policies": []
       },
       {
         "name": "r2",
         "cardinality": 1,
         "vm_template": 0,
         "parents": [
           "r1"
         ],
         "vm_template_contents": "NIC = [\n  NAME = \"_NIC0\",\n  NETWORK_ID = \"$Public\" ]\nCONFIG1 = \"foor2\"\nCONFIG2 = \"barr2\"\n ",
         "elasticity_policies": [],
         "scheduled_policies": []
       },
       {
         "name": "r3",
         "cardinality": 1,
         "vm_template": 0,
         "parents": [
           "r1"
         ],
         "vm_template_contents": "NIC = [\n  NAME = \"_NIC0\",\n  NETWORK_ID = \"$Public\" ]\nCONFIG1 = \"foor3\"\nCONFIG2 = \"barr3\"\n ",
         "elasticity_policies": [],
         "scheduled_policies": []
       }
     ],
     "ready_status_gate": false,
     "automatic_deletion": false,
     "networks": {
       "Public": "M|network|Network with internet access| |id:"
     },
     "shutdown_action": "terminate-hard",
     "registration_time": 1634220409
   }
   

4. Instanciate the service with sunstone admin or user view

The VMs have several time each attributes:

Info for role1 VM

Info for role2 VM

Info for role3 VM

Expected behavior

When instanciating from command line, there is no issue here:

oneflow-template instantiate test-service

There are some networks that require user input. Use the string <<EDITOR>> to launch an editor (e.g. for multi-line inputs)
  * (Public) Network with internet access
    TYPE Existing(1), Create(2), Reserve(3). Press enter for default. 1
    VN ID. 0
ID: 8

Info for role1 VM

Info for role2 VM

Info for role3 VM

Details

• Affected Component: Sunstone
• Hypervisor: KVM
• Version: 6.0.0.2-1.ce on
• OS: Debian GNU/Linux 10 (buster)

Additional context

With the cloud view, the input fields are not filled

Instanciate service with cloud view

Progress Status

• Branch created
• Code committed to development branch
• Testing - QA
• Documentation
• Release notes - resolved issues, compatibility, known issues
• Code committed to upstream release/hotfix branches
• Documentation committed to upstream release/hotfix branches

[baby-gnu]

My use case was to define per service INPUT to fill common values for each roles.

test-service with service wide attributes

{
  "name": "test-service",
  "deployment": "straight",
  "description": "",
  "roles": [
    {
      "name": "r1",
      "cardinality": 1,
      "vm_template": 0,
      "vm_template_contents": "NIC = [\n  NAME = \"_NIC0\",\n  NETWORK_ID = \"$Public\" ]\nCONFIG1 = \"$SERVICE_CONFIG1\"\nCONFIG2 = \"$SERVICE_CONFIG2\"\n ",
      "elasticity_policies": [],
      "scheduled_policies": []
    },
    {
      "name": "r2",
      "cardinality": 1,
      "vm_template": 0,
      "parents": [
        "r1"
      ],
      "vm_template_contents": "NIC = [\n  NAME = \"_NIC0\",\n  NETWORK_ID = \"$Public\" ]\nCONFIG1 = \"$SERVICE_CONFIG1\"\nCONFIG2 = \"$SERVICE_CONFIG2\"\n ",
      "elasticity_policies": [],
      "scheduled_policies": []
    },
    {
      "name": "r3",
      "cardinality": 1,
      "vm_template": 0,
      "parents": [
        "r1"
      ],
      "vm_template_contents": "NIC = [\n  NAME = \"_NIC0\",\n  NETWORK_ID = \"$Public\" ]\nCONFIG1 = \"$SERVICE_CONFIG1\"\nCONFIG2 = \"$SERVICE_CONFIG2\"\n ",
      "elasticity_policies": [],
      "scheduled_policies": []
    }
  ],
  "ready_status_gate": false,
  "automatic_deletion": false,
  "networks": {
    "Public": "M|network|Network with internet access| |id:"
  },
  "custom_attrs": {
    "SERVICE_CONFIG1": "M|text|Service wide value for config1| |",
    "SERVICE_CONFIG2": "M|text|Service wide value for config2| |"
  },
  "shutdown_action": "terminate-hard",
  "registration_time": 1634220409
}

instanciate the service with sunstone admin view

role1 VM info

role2 VM info

role3 VM info

instanciate with could view is broken

instanciate from command line is OK

oneadmin@grichka:~$ oneflow-template instantiate test-service
There are some parameters that require user input. Use the string <<EDITOR>> to launch an editor (e.g. for multi-line inputs)
  * (SERVICE_CONFIG1) Service wide value for config1
    Service value for config1
  * (SERVICE_CONFIG2) Service wide value for config2
    Service value for config2
There are some networks that require user input. Use the string <<EDITOR>> to launch an editor (e.g. for multi-line inputs)
  * (Public) Network with internet access
    TYPE Existing(1), Create(2), Reserve(3). Press enter for default. 1
    VN ID. 0
ID: 12

[baby-gnu]

Another issue I have is:

• define a VM template without the onegate token to make the VM usable when onegate is not enabled
• set the TOKEN = "YES" in vm_template_contents because my service requires onegate.

To reproduce:

1. Import ttylinux Apps

2. Create the service template

   {
     "name": "test-service",
     "deployment": "straight",
     "description": "",
     "roles": [
       {
         "name": "r1",
         "cardinality": 1,
         "vm_template": 0,
         "vm_template_contents": "NIC = [\n  NAME = \"_NIC0\",\n  NETWORK_ID = \"$Public\" ]\nCONFIG1 = \"$SERVICE_CONFIG1\"\nCONFIG2 = \"$SERVICE_CONFIG2\"\nTOKEN = \"YES\"\n ",
         "elasticity_policies": [
   
         ],
         "scheduled_policies": [
   
         ]
       },
       {
         "name": "r2",
         "cardinality": 1,
         "vm_template": 0,
         "parents": [
           "r1"
         ],
         "vm_template_contents": "NIC = [\n  NAME = \"_NIC0\",\n  NETWORK_ID = \"$Public\" ]\nCONFIG1 = \"$SERVICE_CONFIG1\"\nCONFIG2 = \"$SERVICE_CONFIG2\"\nTOKEN = \"YES\"\n ",
         "elasticity_policies": [
   
         ],
         "scheduled_policies": [
   
         ]
       },
       {
         "name": "r3",
         "cardinality": 1,
         "vm_template": 0,
         "parents": [
           "r1"
         ],
         "vm_template_contents": "NIC = [\n  NAME = \"_NIC0\",\n  NETWORK_ID = \"$Public\" ]\nCONFIG1 = \"$SERVICE_CONFIG1\"\nCONFIG2 = \"$SERVICE_CONFIG2\"\nTOKEN = \"YES\"\n ",
         "elasticity_policies": [
   
         ],
         "scheduled_policies": [
   
         ]
       }
     ],
     "ready_status_gate": false,
     "automatic_deletion": false,
     "networks": {
       "Public": "M|network|Network with internet access| |id:"
     },
     "custom_attrs": {
       "SERVICE_CONFIG1": "M|text|Service wide value for config1| |",
       "SERVICE_CONFIG2": "M|text|Service wide value for config2| |"
     },
     "shutdown_action": "terminate-hard",
     "registration_time": 1634220409
   }
   

onevm show 46

USER TEMPLATE
CONFIG1="s-config1"
CONFIG1="$SERVICE_CONFIG1"
CONFIG2="s-config2"
CONFIG2="$SERVICE_CONFIG2"
HOT_RESIZE=[
  CPU_HOT_ADD_ENABLED="NO",
  MEMORY_HOT_ADD_ENABLED="NO" ]
HYPERVISOR="kvm"
INPUTS_ORDER="CONFIG1,CONFIG2"
LOGO="images/logos/linux.png"
MEMORY_UNIT_COST="MB"
ROLE_NAME="r1"
SERVICE_CONFIG1="s-config1"
SERVICE_CONFIG2="s-config2"
SERVICE_ID="18"
TOKEN="YES"
USER_INPUTS=[
  CONFIG1="M|text|first config| |",
  CONFIG2="M|text|second config| |" ]

VIRTUAL MACHINE TEMPLATE
AUTOMATIC_DS_REQUIREMENTS="(\"CLUSTERS/ID\" @> 0)"
AUTOMATIC_NIC_REQUIREMENTS="(\"CLUSTERS/ID\" @> 0)"
AUTOMATIC_REQUIREMENTS="(CLUSTER_ID = 0) & !(PUBLIC_CLOUD = YES) & !(PIN_POLICY = PINNED)"
CONTEXT=[
  CONFIG1="s-config1",
  CONFIG2="s-config2",
  DISK_ID="1",
  ETH0_CONTEXT_FORCE_IPV4="",
  ETH0_DNS="192.168.232.2",
  ETH0_EXTERNAL="",
  ETH0_GATEWAY="192.168.230.254",
  ETH0_GATEWAY6="",
  ETH0_IP="192.168.230.210",
  ETH0_IP6="",
  ETH0_IP6_PREFIX_LENGTH="",
  ETH0_IP6_ULA="",
  ETH0_MAC="02:00:c0:a8:e6:d2",
  ETH0_MASK="255.255.255.0",
  ETH0_METRIC="",
  ETH0_METRIC6="",
  ETH0_MTU="",
  ETH0_NETWORK="192.168.230.0",
  ETH0_SEARCH_DOMAIN="",
  ETH0_VLAN_ID="4",
  ETH0_VROUTER_IP="",
  ETH0_VROUTER_IP6="",
  ETH0_VROUTER_MANAGEMENT="",
  NETWORK="YES",
  SSH_PUBLIC_KEY="",
  TARGET="hda" ]
CPU="0.1"
GRAPHICS=[
  LISTEN="0.0.0.0",
  PORT="5946",
  TYPE="VNC" ]
MEMORY="128"
OS=[
  BOOT="",
  UUID="66bf5e6c-6b64-4066-82d7-18f130b43412" ]
TEMPLATE_ID="0"
TM_MAD_SYSTEM="ssh"
VMID="46"

[FrederickBor]

@tinova PRs to be approved:

• Code 5.12
• Docs 5.12
• Code 6.0 and master
• Docs 6.0

[FrederickBor]

Reopening due to an error with the user inputs

[sbbarragan]

PRs to merge:

• one: https://github.com/OpenNebula/one-ee/pull/1593