Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM owner with USE rights can resize disk #6068

Closed
3 tasks
kvakanet opened this issue Dec 31, 2022 · 2 comments
Closed
3 tasks

VM owner with USE rights can resize disk #6068

kvakanet opened this issue Dec 31, 2022 · 2 comments

Comments

@kvakanet
Copy link

Description
Owner VM with USE rights can resize disk.

To Reproduce

  1. Маке VM with disk size 5 Gb
  2. Set Rights VM
PERMISSIONS                                                                     
OWNER               : u--                 
GROUP               : ---                 
OTHER               : ---                 
  1. Login into sunstore cloud view by owner vm

Expected behavior
Not available to change the size of the disk, as well as not available to change other resources

Details

  • Affected Component: one, Sunstone
  • Hypervisor: KVM
  • Version: 6.4.0 CE

Additional context
It may be possible to extend the usage rights USE to reboot the VM since the VNC is available in the cloud view
send Ctrl-Alt-Del.

Progress Status

  • Code committed
  • Testing - QA
  • Documentation (Release notes - resolved issues, compatibility, known issues)
@paczerny
Copy link
Member

Internal note: It seems the RequestManagerDiskResize::request_execute is missing call vm_authorization
Maybe also disk-attach doesn't respect the permissions, we should check also other VM actions

@paczerny paczerny self-assigned this Jan 29, 2023
@paczerny paczerny added this to the Release 6.6.1 milestone Jan 29, 2023
paczerny pushed a commit to OpenNebula/docs that referenced this issue Jan 30, 2023
@paczerny
Copy link
Member

Fixed authorization for onevm disk-resize. Authorization for other VM commands are ok. Only onevm create-chart returns wrong error code, fixed.

PRs

rsmontero pushed a commit to OpenNebula/docs that referenced this issue Jan 31, 2023
rsmontero added a commit to OpenNebula/docs that referenced this issue Jan 31, 2023
rsmontero pushed a commit that referenced this issue Feb 1, 2023
Also fix error code for onevm create-chart

(cherry picked from commit 18a4796ea16704966ba34a04f08dbb2068479ab8)
rsmontero pushed a commit that referenced this issue Mar 1, 2023
Also fix error code for onevm create-chart

(cherry picked from commit 18a4796ea16704966ba34a04f08dbb2068479ab8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants