[FSunstone] User error "Restricted attribute DISK" when updating VM Template

[FrederickBor]

Description
When trying to update a VM template the following error is thrown: [one.template.update] Cannot update template. Tried to change restricted attribute: DISK

To Reproduce

1. Create a user
2. Download an app from the marketplace
3. Try to update the app VM Template
4. The described error is thrown

Expected behavior
Users without special permission can edit their templates.

Details

• Affected Component: FSunstone
• Hypervisor: [e.g. KVM]
• Version: 6.6, master

Additional context
The error was detected by trying to attach a NIC to a VM Template, It will be a good idea to verify that users can attach the NIC after the changes

Progress Status

• Code committed
• Testing - QA
• Documentation (Release notes - resolved issues, compatibility, known issues)

[dann1]

It looks like the API call being issued by FireEdge is trying to update the DISK attribute with information that the user is not inputting at all

On a template looking like this

DISK=[
  IMAGE_ID="244" ]

issuing a template update, without altering the DISK section whatsoever, the resulting DISK ends up like this

DISK=[
  ALLOW_ORPHANS="FORMAT",
  CLONE="YES",
  CLONE_TARGET="SYSTEM",
  CLUSTER_ID="0",
  DATASTORE="default",
  DATASTORE_ID="1",
  DEV_PREFIX="vd",
  DISK_ID="0",
  DISK_SNAPSHOT_TOTAL_SIZE="0",
  DISK_TYPE="FILE",
  DRIVER="qcow2",
  FORMAT="qcow2",
  IMAGE="rocky9",
  IMAGE_ID="244",
  IMAGE_STATE="1",
  LN_TARGET="NONE",
  NAME="DISK0",
  ORIGINAL_SIZE="4096",
  READONLY="NO",
  SAVE="NO",
  SIZE="4096",
  SOURCE="/var/lib/one//datastores/1/d731fc4ee8b8c9e260c7d2755cf0ec61",
  TM_MAD="qcow2",
  TYPE="FILE" ]

The update call was issued as oneadmin, and the changes made were related to live resize attributes.

[tinova]

Reopening, we need to update the following guides

• https://docs.opennebula.io/6.6/management_and_operations/references/template.html?highlight=restricted#restricted-attributes
• https://docs.opennebula.io/6.6/management_and_operations/vm_management/vm_templates.html#preparing-vm-templates-for-end-users