Wrong RUNNING_*_USED quota after VM transition from poweroff -> done

[paczerny]

Description
RUNNING_*_USED quota includes RUNNING_MEMORY_USED, RUNNING_CPU_USED, RUNNING_VMS_USED.
The command onevm terminate on VM in poweroff state temporary increase the RUNNING_*_USED quotas. If this exceeds the RUNNING_* quota, the command succeeds but the RUNNING_*_USED quotas are corrupted.

To Reproduce
As regular user userA create, deploy and poweroff VM

onevm create --cpu 1 --memory 1
onevm deploy <vm_id> <host_id>
onevm poweroff 

As admin set user running quota:

echo "VM = [ RUNNING_CPU = 1 ] " >quota.tmpl
oneuser quota userA quota.tmpl

Terminate the VM onevm terminate <vm_id>.
The oneuser show userA shows negative RUNNING_*_USED values.

Expected behavior
Correct values for the RUNNING_*_USED quotas after onevm terminate

Details

• Affected Component: oned
• Version: Tested on 6.8, but applies to all previous versions

Additional context
Same issue is for VM in suspend, stop, undeployed state

Progress Status

• Code committed
• Testing - QA
• Documentation (Release notes - resolved issues, compatibility, known issues)

[paczerny]

Right now I'm working on #6341 , I've discover mre commands which corrupts the quota. I'll list all quota bugs here:

• VM state poweroff, stop, suspend or undeployed -> command onevm chown, onevm chgrp corrupts VMS_USED quota
• VM state poweroff -> command onevm undeploy corrupts RUNNING_* quotas