Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disk snapshot size #6503

Closed
3 tasks
rsmontero opened this issue Feb 12, 2024 · 0 comments · Fixed by OpenNebula/docs#2858
Closed
3 tasks

Disk snapshot size #6503

rsmontero opened this issue Feb 12, 2024 · 0 comments · Fixed by OpenNebula/docs#2858
Assignees
@paczerny
Labels
Category: Core & System Category: Drivers - Storage Priority: Normal Status: Accepted Type: Bug
Milestone
Release 6.8.3

Comments

@rsmontero
Copy link
Member

rsmontero commented Feb 12, 2024 •
edited by tinova

Description
When a new snapshot is created the current SIZE of the associated disk is used:

This may not be accurate when:

  1. The disk is resized
  2. The disk is reverted to a previous (smaller) snapshot
  3. A new snapshot is then taken from this reverted snapshot (as it will use the SIZE set in step 1)

This issue is to review which size is better to use (or if the DISK/SIZE needs to be updated) for create and revert operation. Note that this depends on the snapshot mode.

To Reproduce
see above

Expected behavior
To be check

Details

  • Affected Component: Storage
  • Hypervisor: KVM
  • Version: all

Additional context
Add any other context about the problem here.

Progress Status

  • Code committed
  • Testing - QA
  • Documentation (Release notes - resolved issues, compatibility, known issues)
@rsmontero rsmontero added this to the Release 6.8.3 milestone Feb 12, 2024
@paczerny paczerny self-assigned this Feb 27, 2024
paczerny added a commit to OpenNebula/docs that referenced this issue Feb 27, 2024
@paczerny
B OpenNebula/one#6503: Update release notes
6971b4e
@paczerny paczerny linked a pull request Feb 27, 2024 that will close this issue
B OpenNebula/one#6503: Update release notes OpenNebula/docs#2858
Merged
2 tasks
rsmontero pushed a commit that referenced this issue Mar 11, 2024
@paczerny @rsmontero
B #6503: Fix disk size after disk-snapshot-revert
1781421 
When a disk with snapshots is resized and a subsequent revert operation
is performed, the following actions are now done:

* DISK/SIZE is updated to reflect the active snapshot size
* Quotas are updated to account the space freed after the resize
  operation
rsmontero pushed a commit that referenced this issue Mar 11, 2024
@paczerny @rsmontero
B #6503: Fix disk size after disk-snapshot-revert
d2aaf2c 
When a disk with snapshots is resized and a subsequent revert operation
is performed, the following actions are now done:

* DISK/SIZE is updated to reflect the active snapshot size
* Quotas are updated to account the space freed after the resize
  operation

(cherry picked from commit 1781421)
rsmontero pushed a commit that referenced this issue Mar 11, 2024
@paczerny @rsmontero
B #6503: Fix disk size after disk-snapshot-revert
57efabf 
When a disk with snapshots is resized and a subsequent revert operation
is performed, the following actions are now done:

* DISK/SIZE is updated to reflect the active snapshot size
* Quotas are updated to account the space freed after the resize
  operation

(cherry picked from commit 1781421)
(cherry picked from commit d2aaf2c)
rsmontero pushed a commit to OpenNebula/docs that referenced this issue Mar 11, 2024
@paczerny
B OpenNebula/one#6503: Update release notes (#2858)
a23e663
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paczerny paczerny

Labels
Category: Core & System Category: Drivers - Storage Priority: Normal Status: Accepted Type: Bug
Projects
None yet
Milestone
Release 6.8.3
Development

Successfully merging a pull request may close this issue.

B OpenNebula/one#6503: Update release notes OpenNebula/docs
2 participants
@rsmontero @paczerny