fix for bug #4593 #104
Merged
fix for bug #4593 #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi Developers, http://dev.opennebula.org/issues/4593 When VM in UNKNOWN state is rescheduled it can not be migrated anymore because a check in VirtualMachineMigrate::request_execute is not satisfied due to previous history record not closed properly. https://github.com/OpenNebula/one/blob/master/src/rm/RequestManagerVirtualMachine.cc#L1097 The suggested patch updates(closes) previous history record properly (I hope) and the VM is in proper state then. Kind Regards, Anton Todorov
|
Needs to handle the other PROLOG_MIGRATE states and failure. |
|
Hi Anton, After reviewing this, I've decided to move your changes to the action. This case is slightly different to the others as the capacity is decremented before issuing the prolog. So I prefer to treat the history record in a similar way to a POWEROFF/SUSPEND migration, where the actual registry is closed. All changes are now in master if you want to give them a try, but I basically moved the update from the callback to the trigger. THANKS! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Developers,
http://dev.opennebula.org/issues/4593
When VM in UNKNOWN state is rescheduled it can not be migrated anymore because a check in VirtualMachineMigrate::request_execute is not satisfied due to previous history record not closed properly.
https://github.com/OpenNebula/one/blob/master/src/rm/RequestManagerVirtualMachine.cc#L1097
The suggested patch updates(closes) previous history record properly (I hope) and the VM is in proper state then.
Kind Regards,
Anton Todorov