Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B #1666: Marketplace driver expects always an image to import #3065

Closed
wants to merge 1 commit into from
Closed

B #1666: Marketplace driver expects always an image to import #3065

wants to merge 1 commit into from

Conversation

al3xhh
Copy link
Contributor

@al3xhh al3xhh commented Mar 12, 2019 

* Add new time of MarketPlaceApp image: NO_IMAGE
* Modify the OCA, so if the type is NO_IMAGE no image is created
* Modify Sunstone, so if the type is NO_IMAGE no ds is needed

vholer
vholer reviewed Mar 12, 2019
View reviewed changes
include/MarketPlaceApp.h Outdated
/**
* MarketPlaceApp format with no images
*/
const std::set<std::string> no_image = {"ami"};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would propose not to depend on ami image format.
If this is the most straightforward way, let's use external, remote, or cloud keywords to identify no image to import.

@al3xhh
Copy link
Contributor Author

al3xhh commented Mar 12, 2019

Applies to master and 5.8

@tinova tinova requested a review from rsmontero March 12, 2019 14:56
B OpenNebula#1666: Marketplace driver expects always an image to import
03e2a9b 
    * Use VMTEMPLATE marketapp type
    * Modify the OCA, so if the type is VMTEMPLATE no image is created
    * Modify Sunstone, so if the type is VMTEMPLATE no ds is needed
@rsmontero rsmontero closed this Mar 17, 2019
@al3xhh al3xhh deleted the bug-1666 branch March 18, 2019 09:41
rsmontero pushed a commit that referenced this pull request May 28, 2024
@1gramos
F #6053: Fix Ceph restore (#3065)
cff2bb6 
Fix wrong handling of the two datastores involved (backup+ceph)

Signed-off-by: Guillermo Ramos <gramos@opennebula.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vholer vholer vholer left review comments

@rsmontero rsmontero Awaiting requested review from rsmontero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@al3xhh @vholer @rsmontero