Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new collections to backup script #197

Merged
merged 2 commits into from Oct 30, 2020
Merged

Adding new collections to backup script #197

merged 2 commits into from Oct 30, 2020

Conversation

teone
Copy link
Member

@teone teone commented Oct 29, 2020

Describe the PR
Backup all the collections in the firestore DB

@teone teone requested review from hwchiu and ccascone October 29, 2020 23:06
@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #197 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #197   +/-   ##
=======================================
  Coverage   81.25%   81.25%           
=======================================
  Files          14       14           
  Lines         576      576           
  Branches       66       66           
=======================================
  Hits          468      468           
  Misses        108      108           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a710fe0...3b3d9e6. Read the comment docs.

functions/lib/backup.js Outdated Show resolved Hide resolved
functions/lib/backup.js Outdated Show resolved Hide resolved
Copy link
Contributor

@ccascone ccascone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teone teone merged commit 07b385d into master Oct 30, 2020
@teone teone deleted the feature/backup branch November 2, 2020 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants