Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix git-annex access issues for CLI #2945

Merged
merged 4 commits into from
Nov 25, 2023
Merged

Fix git-annex access issues for CLI #2945

merged 4 commits into from
Nov 25, 2023

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Nov 21, 2023

This fixes a bug in retrieveKey where the wrong streaming API was used preventing download of keys and improves performance/reliability (especially on Node 19 or later) where storeKey requests would sometimes hang.

One small change to allow tranferKey providers to override headers without losing the authorization header.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a49b7af) 64.89% compared to head (2c41598) 64.89%.

❗ Current head 2c41598 differs from pull request most recent head d90691a. Consider uploading reports for the commit d90691a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2945   +/-   ##
=======================================
  Coverage   64.89%   64.89%           
=======================================
  Files         378      378           
  Lines       24230    24230           
  Branches      868      868           
=======================================
  Hits        15723    15723           
  Misses       8507     8507           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nellh nellh merged commit 39f6383 into master Nov 25, 2023
12 checks passed
@nellh nellh deleted the fix/git-annex-cli-bugs branch November 25, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant