fix(worker): Add test and character set detection for non-utf8 files #2965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nellh
force-pushed
the
fix/non-utf8-file-crash
branch
from
0b7225e
to
5f27314
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2965 +/- ##
=======================================
Coverage 64.91% 64.91%
=======================================
Files 378 379 +1
Lines 24317 24320 +3
Branches 878 877 -1
=======================================
+ Hits 15785 15787 +2
- Misses 8532 8533 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The worker would attempt to decode everything as UTF-8 and crash if a file could not be decoded as UTF-8. While BIDS requires most files to be UTF-8, it's useful for OpenNeuro to serve them and leave warnings/errors about invalid character sets to validation.
Fixes #2949 and uses the file causing issues there for the test.