Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Show file metadata for schema validator issues #2996

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Feb 15, 2024

Main issue is the map was being iterated over so keys and values were being displayed here. This iterates over the schema validator file issues and handles file metadata better.

Fixes #2995

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (7bd1525) 65.27% compared to head (8babdda) 65.25%.

Files Patch % Lines
...c/scripts/validation/validation-results.issues.jsx 26.08% 17 Missing ⚠️
...pts/validation/validation-results.issues.issue.jsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2996      +/-   ##
==========================================
- Coverage   65.27%   65.25%   -0.03%     
==========================================
  Files         382      382              
  Lines       24594    24599       +5     
  Branches      883      883              
==========================================
- Hits        16053    16051       -2     
- Misses       8541     8548       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nellh nellh merged commit 1f3ba55 into master Feb 29, 2024
6 of 8 checks passed
@nellh nellh deleted the schema-validator-file-fix branch February 29, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema validation results are sparse
1 participant