fix(app): Update to React 18 and replace jsx-to-markdown with react-markdown #3009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3009 +/- ##
=======================================
Coverage 65.23% 65.24%
=======================================
Files 382 382
Lines 24608 24612 +4
Branches 883 885 +2
=======================================
+ Hits 16053 16058 +5
+ Misses 8555 8554 -1 ☔ View full report in Codecov by Sentry. |
effigies
reviewed
Mar 1, 2024
|
|
||
| <li> | ||
| test content | ||
| </li> |
There was a problem hiding this comment.
This seems to lose a level of nesting. Is this a reasonable interpretation of the input markdown?
There was a problem hiding this comment.
This is the input.
* Markdown document
<br><br>
* test content
react-markdown is more accurate to GitHub's behavior (not nesting) since the second * is not indented as much as the content of the first list item.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #3000 by replacing the library used with the more capable react-markdown.
The main extra change needed here was updating to React 18.