Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Restrict data table date display to four common formats #3014

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Mar 11, 2024

This prevents the data table from converting common integers into dates.

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 65.26%. Comparing base (3a000a1) to head (d17b6a4).

Files Patch % Lines
...penneuro-app/src/scripts/components/data-table.tsx 88.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3014      +/-   ##
==========================================
+ Coverage   65.24%   65.26%   +0.02%     
==========================================
  Files         382      382              
  Lines       24610    24632      +22     
  Branches      885      889       +4     
==========================================
+ Hits        16056    16076      +20     
- Misses       8554     8556       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nellh nellh merged commit 577a030 into master Mar 11, 2024
8 checks passed
@nellh nellh deleted the tsv-date-fix branch March 11, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant