Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI/UX #48

Merged
merged 2 commits into from
Sep 12, 2017
Merged

UI/UX #48

merged 2 commits into from
Sep 12, 2017

Conversation

Xesme
Copy link
Contributor

@Xesme Xesme commented Sep 8, 2017

fixes #18

@nellh nellh self-requested a review September 8, 2017 18:04
nellh
nellh requested changes Sep 11, 2017
View reviewed changes
Copy link
Contributor

@nellh nellh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good and the hidden functionality works. One issue with a related commit (efe5fb1) causes some dropdown issues.

@nellh
Copy link
Contributor

nellh commented Sep 11, 2017

Here's a screenshot of the dropdown issue.

commit efe5fb11 issue

@nellh nellh mentioned this pull request Sep 12, 2017
Closed
@nellh nellh merged commit 93f5d53 into master Sep 12, 2017
nellh added a commit that referenced this pull request Mar 10, 2020
@nellh
Merge pull request #48 from rwblair/789-s3-access
92b4e59 
Allow datasets to publish objects to s3 as public via env variable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nellh nellh nellh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App Definition Parameters UI Improvements
2 participants
@Xesme @nellh