Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSD Make stumples over file names which contain spaces #799

Open
sikmir opened this issue Nov 19, 2016 · 3 comments
Open

BSD Make stumples over file names which contain spaces #799

sikmir opened this issue Nov 19, 2016 · 3 comments
Labels

Comments

@sikmir
Copy link
Member

sikmir commented Nov 19, 2016

BSD Make (in contrast to GNU Make) requires that targets with whitespaces must be enclosed in quotes.
Easiest way to fix is rename.

Steps to reproduce

$ make Mapper-manual
Built target Mapper-manual-pages
make[3]: don't know how to make doc/manual/Mapper\. Stop

Root cause:

$ grep "doc/manual/Mapper\\" doc/manual/CMakeFiles/Mapper-manual.dir/build.make
doc/manual/CMakeFiles/Mapper-manual: doc/manual/Mapper\ 0.6.6\ Manual.qhc
doc/manual/Mapper\ 0.6.6\ Manual.qhc: doc/manual/Manual.qhcp
doc/manual/Mapper\ 0.6.6\ Manual.qhc: doc/manual/html/index.qhp
doc/manual/Mapper\ 0.6.6\ Manual.qhc: doc/manual/html/index.qhp
doc/manual/Mapper\ 0.6.6\ Manual.qch: doc/manual/Mapper\ 0.6.6\ Manual.qhc
Mapper-manual: doc/manual/Mapper\ 0.6.6\ Manual.qhc
Mapper-manual: doc/manual/Mapper\ 0.6.6\ Manual.qch
$ make Mapper_symbol_sets
make[1]: don't know how to make symbol\. Stop

Root cause:

$ grep "symbol\\" CMakeFiles/Makefile2
symbol\ sets/all: symbol\ sets/CMakeFiles/Mapper_symbol_sets.dir/all
...

Actual behaviour

Build fails.

Expected behaviour

Build successed.

Configuration

Mapper Version: latest
Operating System: any BSD

@dg0yt
Copy link
Member

dg0yt commented Nov 19, 2016

I will look into this when I finished the restructuring (simplifying) the build system (#674).

@dg0yt dg0yt added this to the v0.7.0 milestone Nov 19, 2016
@dg0yt
Copy link
Member

dg0yt commented Nov 23, 2016

Isn't this an issue of using a matching combination of CMake generator and native build system?
Do we need to support BSD make? Alternatives (GNU make, Ninja) should be available where needed. The current configuration works out of the box for a wide variety of systems.

@sikmir
Copy link
Member Author

sikmir commented Nov 23, 2016

I don't know if it's possible to force CMake to generate bsd-compatible makefile (actually just enquote the paths with whitespaces). Anyway, this is very minor issue and created just to be aware of it. Surely it's not a problem at all to use 'gmake' instead of 'make' on BSD systems.

@dg0yt dg0yt added the build label Apr 12, 2017
@dg0yt dg0yt removed this from the v0.7.0 milestone Apr 12, 2017
@dg0yt dg0yt changed the title [Build] handling file names with spaces with BSD Make BSD Make stumples over file names which contain spaces Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants