Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache incorrectly returns objects with all permissions allowed #2

Closed
wsot opened this issue Jan 19, 2013 · 1 comment
Closed

Cache incorrectly returns objects with all permissions allowed #2

wsot opened this issue Jan 19, 2013 · 1 comment
Labels
bug

Comments

@wsot
Copy link

wsot commented Jan 19, 2013

In the development branch, the caching code misidentifies the item being restored from cache as a 'stub', rather than a true PrivacySettings object. The effect of this is that when settings are being restored from cache, all activity is permitted.
@wsot
Copy link
Author

wsot commented Jan 19, 2013

This has been fixed in all current -devel branches.

@wsot wsot closed this as completed Jan 19, 2013
wsot pushed a commit that referenced this issue Jan 21, 2013
@imilka
Constants for Samsung telephony #2
cc1f1dd
wsot pushed a commit that referenced this issue Jan 21, 2013
@imilka
Values for Samsung telephony #2
9bde376
wsot pushed a commit that referenced this issue Jan 23, 2013
@veeti
Clean up, simplify and fix AlarmTile class and logic
54639e2 
This commit cleans up the AlarmTile class by removing the unnecessary
listener on the alarm intent. It now listens only to the next alarm
setting value, which was fetched after receiving the intent anyway.

These changes also fix a bug that would cause the tile to not show up
after some actions, like reordering the tiles due to the visibility not
being set on tile creation.

Lastly, some minor code styling issues have been fixed.

Patch set #2: collapse onNextAlarmChanged into onChangeUri, remove
mEnabled, use TextUtils to check for string emptiness and mark
updateQuickSettings explicitly as public.

Change-Id: Ic5871a9cc4874f33181dfac14e25a89499c182f2
wsot pushed a commit that referenced this issue Feb 1, 2013
@Zaphod-Beeblebrox @KhasMek
LastApp Toggle [1/2]
810c39b 
Creates an action useable by NavBar & NavRing to toggle
between most recent apps.  Will try to ignore the launcher
when possible.  ie, if you've just rebooted and have not opened any
apps, it will do nothing.  if you open 1 app, it will toggle between
that 1 app and the launcher.  Once two apps have been opened, it will
toggle between those two apps.
It's kind of like opening recents and hitting your #2 slot repeatedly

PS 2:  Add Icons from Hoolm.  {Thanks!}
       Re-wrote the logic for selecting next app.  Rather than
toggling back to launcher if only 1 app open, it does nothing.
toggling only occurs now when there are at least two apps open.
One issue that I still need to work out is that 'Recents' is somehow
showing up as a valid target to toggle to.  It shouldn't.

ps 3:  getRunningTasks() does not filter out 'Excludefromrecents'.
Thus we need checks for 'default launcher' and SystemUI.
as I write this, I realize I might be able to query the
ExcludeFromRecents flag of the package a bit more easily.

ps 4: Whitespace fix.
ps 5: one more whitespace fix.
ps 6: remove unnecessary dependency

Signed-off-by: Zaphod <mwilson@acesappraisal.com>
Change-Id: I0b59121b07b9ba44a2837a8db0266441ed82f9a3
wsot pushed a commit that referenced this issue Feb 21, 2013
@Keltek
Czech: fixed translation, added new strings
f65858e 
patch #2 - fixed typos
patch #3 - some fixes and translated unintentionally untranslated
  strings

Change-Id: I288bf43a027286c4c08f2a7761fc2bc19b77f04c
mateor added a commit that referenced this issue Apr 10, 2013
@mateor
MediaRecorder: Fix syntax error breaking file (#2)
6de2429 
We were missing a closed quote, introduced 9ba8297
mateor added a commit that referenced this issue Apr 10, 2013
@mateor
MediaRecorder: Fix syntax error breaking file (#2)
58aa913 
We were missing a closed quote, introduced 9ba8297

Conflicts:
	media/java/android/media/MediaRecorder.java
mateor pushed a commit that referenced this issue Jul 30, 2013
@alonalbert
Add sync reason to dumpsys
57286f9 
Also:
 * add a second history section that logs
 * log mesg as text instead of number
 * dump Sync Status as a table

 Sample log:
Recent Sync History
  #1  : 2012-10-11 15:06:11     USER    0.4s            aagmtest1@gmail.com/com.google u0  com.android.calendar                                  com.google.android.calendar
  #2  : 2012-10-11 15:06:11     USER    0.1s            aagmtest1@gmail.com/com.google u0  subscribedfeeds                                       android.uid.system:1000
    mesg=parse-error
  #3  : 2012-10-11 15:06:11     USER    0.0s            aagmtest1@gmail.com/com.google u0  com.google.android.apps.uploader.PicasaUploadProvider android.uid.system:1000
  #4  : 2012-10-11 15:06:10     USER    0.1s            aagmtest1@gmail.com/com.google u0  com.google.android.gms.plus.action                    android.uid.system:1000

Recent Sync History Extras
  #1  : 2012-10-11 15:06:11     USER   aagmtest1@gmail.com/com.google u0  com.android.calendar                                  Bundle[{feed=aagmtest1@gmail.com, force=true, ignore_settings=true, ignore_backoff=true}]
  #2  : 2012-10-11 15:06:11     USER   aagmtest1@gmail.com/com.google u0  subscribedfeeds                                       Bundle[{ignore_backoff=true, force=true, ignore_settings=true}]
  #3  : 2012-10-11 15:06:11     USER   aagmtest1@gmail.com/com.google u0  com.google.android.apps.uploader.PicasaUploadProvider Bundle[{ignore_backoff=true, force=true, ignore_settings=true}]
  #4  : 2012-10-11 15:06:10     USER   aagmtest1@gmail.com/com.google u0  com.google.android.gms.plus.action                    Bundle[{ignore_backoff=true, force=true, ignore_settings=true}]

Sync Status
Account aagmtest1@gmail.com u0 com.google
=======================================================================
Authority                                           Syncable  Enabled  Delay  Loc  Poll  Per  Serv  User  Tot  Time  Last Sync            Periodic
-------------------------------------------------------------------------------------------------------------------------------------------------------------
com.google.android.apps.currents                    1         true            0    2     1    2     1     6    0:35  PERIODIC SUCCESS     86400
                                                                                                                     2012-10-12 14:59:40  2012-10-13 14:58:13
com.google.android.music.MusicContent               1         true            0    0     1    2     1     4    0:09  PERIODIC SUCCESS     86400
                                                                                                                     2012-10-12 14:59:18  2012-10-13 14:58:13
com.google.android.gms.plus.action                  1         true            0    0     1    1     1     3    0:00  PERIODIC SUCCESS     86400
                                                                                                                     2012-10-12 14:59:15  2012-10-13 14:58:13
com.google.android.apps.magazines                   1         true            0    1     1    2     1     5    0:14  PERIODIC SUCCESS     86400
                                                                                                                     2012-10-12 14:59:00  2012-10-13 14:58:13

Change-Id: Iffeb825e4b4f6217940a39b0dd71e06856f08f3f
@chenjunqiang chenjunqiang mentioned this issue Nov 5, 2013
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wsot