Skip to content

Commit

Permalink
Migrate to INDI v2.0.0+ (#1089)
Browse files Browse the repository at this point in the history 
* Migrate to INDI v2.0.0+

* Add INDI Win32 client library v2.0.3
  • Loading branch information
@knro
knro committed Aug 27, 2023
1 parent 8d185c8 commit 9ff645f
Show file tree
Hide file tree
Showing 18 changed files with 2,311 additions and 2,474 deletions.
4 changes: 1 addition & 3 deletions CMakeLists.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -429,9 +429,7 @@ set(phd2_SRC
${phd_src_dir}/phdconfig.cpp
${phd_src_dir}/phdconfig.h
${phd_src_dir}/phdcontrol.cpp
${phd_src_dir}/phdcontrol.h
${phd_src_dir}/phdindiclient.cpp
${phd_src_dir}/phdindiclient.h
${phd_src_dir}/phdcontrol.h
${phd_src_dir}/phdupdate.cpp
${phd_src_dir}/phdupdate.h
${phd_src_dir}/pierflip_tool.cpp
Expand Down
Loading

1 comment on commit 9ff645f

@bwdev01
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should eliminate any possibility that the libnova_lst method can return 0.0 as a default result. If the use of LIBNOVA is now assured, why can't we eliminate the compile-time ifdef in libnova_lst? Returning 0 as a "punt" is a bad idea, it can easily drive someone's scope and camera into the pier.

Please sign in to comment.