Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigList: fix GSOD on HideHelp if config not set #1425

Merged
merged 1 commit into from
Apr 5, 2018

Conversation

Taapat
Copy link
Member

@Taapat Taapat commented Apr 5, 2018

Add aditional check if config getCurrent() exist to slove GSOD on HideHelp.
For example when create settings backup with plugin SoftwareManager.
You get:

  File "/usr/lib/enigma2/python/mytest.py", line 200, in processDelay
    self.current_dialog.doClose()
  File "/usr/lib/enigma2/python/Screens/Screen.py", line 111, in doClose
    x()
  File "/usr/lib/enigma2/python/Components/ConfigList.py", line 217, in HideHelp
    if "config" in self and (self["config"].getCurrent()[1].__class__.__name__ == 'ConfigText' or self["config"].getCurrent()[1].__class__.__name__ == 'ConfigPassword') and self["config"].getCurrent()[1].help_window and self["config"].getCurrent()[1].help_window.instance is not None:
TypeError: 'NoneType' object has no attribute '__getitem__'

Also small code optimization, thx Huevos.

Add aditional check if config getCurrent() exist to slove GSOD on HideHelp.
For example when create settings backup with plugin SoftwareManager
@WanWizard WanWizard merged commit 7a5461d into OpenPLi:rc Apr 5, 2018
@Taapat Taapat deleted the ConfigList branch April 5, 2018 16:08
WanWizard added a commit that referenced this pull request Apr 6, 2018
ConfigList: fix GSOD on HideHelp if config not set (#1425)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants