Fix Zgemma h9 CPU info (undefined problem) #1658
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/proc/cpuinfo won't give us what we need for h9 instead /proc/stb/info/chipset give us hi3798mv200 After this you will see 1600 MHz (4 cores) too. It seems HiSilicon has this problem so you could use this for future models too.
WanWizard
reviewed
Jul 28, 2018
| if HardwareInfo().get_device_model() in ("h9") and fileCheck("/proc/stb/info/chipset"): | ||
| f = open("/proc/stb/info/chipset", 'r') | ||
| processor = f.readline().strip() | ||
| f.close() | ||
| for line in open("/proc/cpuinfo").readlines(): |
There was a problem hiding this comment.
shouldn't there be an "else", a bit pointless to attempt to execute the for loop...
There was a problem hiding this comment.
No it's not pointless as we get "cpu_count" from /proc/cpuinfo.
And we're getting "cpu_speed" from /sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_max_freq , what a mess LOL
|
Device model check should not be accepted here! |
|
Also three lines to access the file is not done (I know openatv does it Everywhere to make things extra complicated |
|
This code is not in openatv, I did it myself and tested ok. |
|
@littlesat Perhaps give (or point to) an example on how it should be done? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/proc/cpuinfo won't give us what we need for h9 instead /proc/stb/info/chipset give us hi3798mv200
After this you will see 1600 MHz (4 cores) too.
It seems HiSilicon has this problem so you could use this for future models too.
Screenshot: https://forums.openpli.org/topic/28532-merge-requests-for-plis-git/?view=findpost&p=912860