[ServiceInfo] Do not embed color in python code

[nautilus7]

In service info, when pressing the green button, the ecm info is showing in yellow/orange color. This is because the color in embedded in the python code. So, instead of setting a color in the code, we should allow skins to determine what color to use.

After this change, skins will continue to work perfectly fine and the ecm info will be displayed in whatever color is already selected for the service info screen.

[Dima73]

What for?
Do you want to force to rewrite all skins?
Example:
green instead of light green

[nautilus7]

No, you are totally wrong!

The color in the "ecm info" tab will now be the same as in the "pids info" tab. And this color is what is defined for the "infolist" in the skin.

Read the python code before commenting the next time. Thanks.

[Dima73]

https://github.com/OpenPLi/enigma2/search?q=infolist&unscoped_q=infolist

ecm info one line color?

[nautilus7]

I don't understand what you mean by this...

Whatever color is selected by the skin for the self["infolist"] is going to be used for ecm info as well.
Do you have any clue which exactly are the screens I am talking about?
Did you bother checking the code?
Did you bother checking how your current skin works with my change?

[Dima73]

What is incomprehensible here?
If you add color to the "infolist", the all list will be of this color.

[nautilus7]

Even if a skin does not set a color for infolist explicitly, it gets a default color like every skin element.

After my change all possible infolist elements like "pids", "ecm info" and "tuner values" will have that same color defined in the skin.

Why do we need to force all skins to have the ecm info displayed in orange color? There is no reason for that. So remove the hard-coded color from the python code!

[littlesat]

Can you post some screenshots so I can see what’s meant here?

[littlesat]

When you want the skin decides the color or overrules the default do something with attributes.

[nautilus7]

Go to menu --> information --> service info

There you will see the text in whatever color your skin has selected.
Then press the green button to display the "ecm info". The text will be in yellow color BECAUSE this color is defined in the python code!

See how it displays right now:

The skin cannot change the yellow color in the ecm info!
My change will allow the color to be the same as in the other screen (white).

[Dima73]

This two color

[nautilus7]

OK, I'll add an attribute to the code, so it can change colors

[littlesat]

Indeed the skin cannot change the color code that highlights the current 'chosen' ECM. So this change request makes no sense. I agree it should be skinnable. But then we need something to arrange with parameters/attributes that forward the color to python.

[nautilus7]

Believe it or not I had never notice that multiple ecm pids could be listed in that screen. I always thought that only the active pid is displayed there. Now I understand the reason behind the hard-coded color.

[nautilus7]

@littlesat I can make it read a color from the skin instead of using a hard-coded color from the python.

But, I think it would be better to indicate the active ecm pid using a word (e.g. "active") instead of using a different color. It looks much simpler. I don't see why a different color is needed.

What do you think???