Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py files: E101 and E121 PEP8 cleanup #2544

Merged
merged 1 commit into from Apr 29, 2020
Merged

py files: E101 and E121 PEP8 cleanup #2544

merged 1 commit into from Apr 29, 2020

Conversation

persianpros
Copy link
Contributor

Indentation contains mixed spaces and tabs (E101)
Continuation line under-indented for hanging indent (E121)

Indentation contains mixed spaces and tabs (E101)
Continuation line under-indented for hanging indent (E121)
@persianpros
Copy link
Contributor Author

persianpros commented Apr 29, 2020

@littlesat @WanWizard @IanSav

Done in all Open Vision repos, if you're up for it let me know to do it for all PLi repos as well.

And later for ViX, ATV and OE-A because it's the standard.

@IanSav
Copy link
Contributor

IanSav commented Apr 29, 2020

I am more than happy to see all code PEP8 cleaned.

I also standardise quote marks, clean up comments and try to convert variables to camelCase.

@littlesat littlesat merged commit 8acb2de into OpenPLi:develop Apr 29, 2020
@littlesat
Copy link
Member

I did merge it... But it is such huge it is undoable to check for anomalies. So we might consider to revert it later when it breaks something...
I like the job is done, but it would be nicer that such kind of big topics are better coordinated... :) so we see something like this is coming

@persianpros
Copy link
Contributor Author

persianpros commented Apr 29, 2020

@littlesat

In OV I did this for all repos (except python 3 branches for now) and we're testing it and so far with no problem.

I say accept no more PRs and first test this if it was ok then I will send PRs for all other repos, is it ok?

I hope we could do this once for all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants