Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TunerInfo] fix division #3768

Merged
merged 2 commits into from Sep 6, 2023
Merged

[TunerInfo] fix division #3768

merged 2 commits into from Sep 6, 2023

Conversation

Dima73
Copy link
Contributor

@Dima73 Dima73 commented Sep 6, 2023

No description provided.

@ims21
Copy link
Contributor

ims21 commented Sep 6, 2023

int(log(val) // log(2)) is equal int(log(val) / log(2)) ... int(log(val) // log(2)) it's like wearing a belt and suspenders at the same time, imho

When val is not an integer, it must be return int(val * 100 / 65535). No matter if then there is //

@Dima73
Copy link
Contributor Author

Dima73 commented Sep 6, 2023

int(log(val) // log(2)) is equal int(log(val) / log(2)) ... int(log(val) // log(2)) it's like wearing a belt and suspenders at the same time, imho

When val is not an integer, it must be return int(val * 100 / 65535). No matter if then there is //

OK
Closed

@Dima73 Dima73 closed this Sep 6, 2023
@littlesat
Copy link
Member

With the log doing // makes no sense

@Dima73 Dima73 reopened this Sep 6, 2023
@Dima73 Dima73 closed this Sep 6, 2023
@littlesat
Copy link
Member

When you use // I think the conversion to int is not mandatory.

@littlesat littlesat merged commit 94bce8f into OpenPLi:develop Sep 6, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants